lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 24 Oct 2023 17:30:51 -0700
From:   Kees Cook <>
To:     Justin Stitt <>
Cc:     "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,,,
Subject: Re: [PATCH] scsi: csiostor: replace deprecated strncpy with strscpy

On Mon, Oct 23, 2023 at 08:26:13PM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> `hw` is kzalloc'd just before this string assignment:
> |       hw = kzalloc(sizeof(struct csio_hw), GFP_KERNEL);
> ... which means any NUL-padding is redundant.
> Since  CSIO_DRV_VERSION is a small string literal (smaller than
> sizeof(dest)):
> ... there is functionally no change in this swap from strncpy() to
> strscpy(). Nonetheless, let's make the change for robustness' sake -- as
> it will ensure that drv_version is _always_ NUL-terminated.
> Link: [1]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Another direct replacement.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists