linux-kernel - Re: [PATCH] scsi: ufs: qcom: move ufs_qcom_host_reset() to ufs_qcom_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231025074128.GA3648@thinkpad>
Date:   Wed, 25 Oct 2023 13:11:28 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Ziqi Chen <quic_ziqichen@...cinc.com>
Cc:     quic_asutoshd@...cinc.com, quic_cang@...cinc.com,
        bvanassche@....org, mani@...nel.org, beanhuo@...ron.com,
        avri.altman@....com, junwoo80.lee@...sung.com,
        martin.petersen@...cle.com, quic_nguyenb@...cinc.com,
        quic_nitirawa@...cinc.com, quic_rampraka@...cinc.com,
        linux-scsi@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: qcom: move ufs_qcom_host_reset() to
 ufs_qcom_device_reset()

On Tue, Oct 24, 2023 at 07:10:15PM +0800, Ziqi Chen wrote:
> During PISI test, we found the issue that host Tx still bursting after

What is PISI test?

> H/W reset. Move ufs_qcom_host_reset() to ufs_qcom_device_reset() and
> reset host before device reset to stop tx burst.
> 

device_reset() callback is supposed to reset only the device and not the host.
So NACK for this patch.

- Mani

> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 96cb8b5..43163d3 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -445,12 +445,6 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
>  	struct phy *phy = host->generic_phy;
>  	int ret;
>  
> -	/* Reset UFS Host Controller and PHY */
> -	ret = ufs_qcom_host_reset(hba);
> -	if (ret)
> -		dev_warn(hba->dev, "%s: host reset returned %d\n",
> -				  __func__, ret);
> -
>  	/* phy initialization - calibrate the phy */
>  	ret = phy_init(phy);
>  	if (ret) {
> @@ -1709,6 +1703,13 @@ static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba)
>  static int ufs_qcom_device_reset(struct ufs_hba *hba)
>  {
>  	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> +	int ret = 0;
> +
> +	/* Reset UFS Host Controller and PHY */
> +	ret = ufs_qcom_host_reset(hba);
> +	if (ret)
> +		dev_warn(hba->dev, "%s: host reset returned %d\n",
> +				  __func__, ret);
>  
>  	/* reset gpio is optional */
>  	if (!host->device_reset)
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்