[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231025090741.32997-1-hbh25y@gmail.com>
Date: Wed, 25 Oct 2023 17:07:41 +0800
From: Hangyu Hua <hbh25y@...il.com>
To: kristo@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
tony@...mide.com, claudiu.beznea@...rochip.com, robh@...nel.org,
andriy.shevchenko@...ux.intel.com,
dario.binacchi@...rulasolutions.com
Cc: linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org, Hangyu Hua <hbh25y@...il.com>
Subject: [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup
kstrndup and kstrdup_and_replace in clkctrl_get_name can perform
dynamic memory allocation. So clkctrl_name needs to be freed when
provider->clkdm_name is NULL.
Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
Signed-off-by: Hangyu Hua <hbh25y@...il.com>
---
drivers/clk/ti/clkctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
index 607e34d8e289..cb4aa8a45bb2 100644
--- a/drivers/clk/ti/clkctrl.c
+++ b/drivers/clk/ti/clkctrl.c
@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
provider->clkdm_name = kasprintf(GFP_KERNEL,
"%s_clkdm", clkctrl_name);
if (!provider->clkdm_name) {
+ kfree(clkctrl_name);
kfree(provider);
return;
}
--
2.34.1
Powered by blists - more mailing lists