lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d6fdf664bd18eee581a2644e376124e830633045.camel@linaro.org> Date: Wed, 25 Oct 2023 12:22:03 +0100 From: André Draszik <andre.draszik@...aro.org> To: Andi Shyti <andi.shyti@...nel.org> Cc: linux-kernel@...r.kernel.org, krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com, gregkh@...uxfoundation.org, jirislaby@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [PATCH v2] tty: serial: samsung_tty: remove dead code Hi Andi, On Tue, 2023-10-24 at 23:55 +0200, Andi Shyti wrote: > Hi Andre, > > On Thu, Oct 19, 2023 at 11:09:01AM +0100, André Draszik wrote: > > When support for various old platforms was removed in commit > > 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), > > s3c24xx_serial_ops also became unused here because nothing sets > > port > > type TYPE_S3C24XX anymore. > > > > Remove s3c24xx_serial_ops and all the code that's unreachable now. > > > > Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") > > is this really a fix? Or is it a cleanup? I guess from my position it's fixing the issue of dead code, introduced in the commit referenced. Which is of course also a cleanup :-) Not sure... Cheers, Andre
Powered by blists - more mailing lists