linux-kernel - Re: [PATCH RFC 6/8] arm64: dts: qcom: sm8650: add interconnect dependent device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48e2bebc-4f09-4a1f-a9a8-3953523146b8@linaro.org>
Date:   Wed, 25 Oct 2023 13:52:26 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 6/8] arm64: dts: qcom: sm8650: add interconnect
 dependent device nodes

On 25/10/2023 11:10, Konrad Dybcio wrote:
> 
> 
> On 10/25/23 09:47, Neil Armstrong wrote:
>> Add Hardware nodes that depends on an interconnect property to
>> be valid.
>>
>> The includes:
>> - all QUP i2s/spi nodes
>> - PCIe
>> - UFS
>> - SDHCI
>> - Display
>> - HWMON
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> QCOM_ICC_TAG_ALWAYS would be nice.. (see sa8775p)

I'll add those,

Thanks,
Neil

> 
> [...]
> 
>> +            /* Forbid SDR104/SDR50 - broken hw! */
>> +            sdhci-caps-mask = <0x3 0>;
> Have they *still* not fixed that?
> 
> [...]
> 
> There's a whole lot to digest here, but I don't see anything
> obviously wrong..
> 
> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Konrad