linux-kernel - Re: [PATCH] NFS: Fix an off by one in root_nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2023 08:34:35 -0400
From:   Benjamin Coddington <bcodding@...hat.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     trond.myklebust@...merspace.com, anna@...nel.org,
        chuck.lever@...cle.com, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] NFS: Fix an off by one in root_nfs_cat()

On 24 Oct 2023, at 17:47, Christophe JAILLET wrote:

> The intent is to check if the 'dest' is truncated or not. So, >+ should be
> used instead of >, because strlcat() returns the length of 'dest' and 'src'
> excluding the trailing NULL.
>
> Fixes: 56463e50d1fc ("NFS: Use super.c for NFSROOT mount option parsing")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Minor typo in the body: >+ should be >=, otherwise looks right.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben