linux-kernel - Re: [PATCH] scsi: ufs: Leave space for '\0' in utf8 desc string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1msw7ctbi.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 24 Oct 2023 22:46:47 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Daniel Mentz <danielmentz@...gle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tomas Winkler <tomas.winkler@...el.com>,
        Avri Altman <avri.altman@....com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Mars Cheng <marscheng@...gle.com>,
        Bart Van Assche <bvanassche@....org>,
        Yen-lin Lai <yenlinlai@...gle.com>
Subject: Re: [PATCH] scsi: ufs: Leave space for '\0' in utf8 desc string


Daniel,

> utf16s_to_utf8s does not NULL terminate the output string. For us to be
> able to add a NULL character when utf16s_to_utf8s returns, we need to
> make sure that there is space for such NULL character at the end of the
> output buffer. We can achieve this by passing an output buffer size to
> utf16s_to_utf8s that is one character less than what we allocated.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering