[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231025130737.2015468-6-gnstark@salutedevices.com>
Date: Wed, 25 Oct 2023 16:07:34 +0300
From: George Stark <gnstark@...utedevices.com>
To: <pavel@....cz>, <lee@...nel.org>, <vadimp@...dia.com>,
<mpe@...erman.id.au>, <npiggin@...il.com>,
<christophe.leroy@...roup.eu>, <gnstark@...utedevices.com>
CC: <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linuxppc-dev@...ts.ozlabs.org>, <kernel@...rdevices.ru>
Subject: [PATCH 5/8] leds: aw200xx: explicitly unregister LEDs at module's shutdown
LEDs are registered using devm_led_classdev_register() and automatically
unregistered after module's remove(). led_classdev_unregister() calls
led_set_brightness() to turn off the LEDs and module's appropriate callback
uses resources those were destroyed already in module's remove().
So explicitly unregister LEDs at module shutdown.
Signed-off-by: George Stark <gnstark@...utedevices.com>
---
drivers/leds/leds-aw200xx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c
index 96979b8e09b7..3da0923507ec 100644
--- a/drivers/leds/leds-aw200xx.c
+++ b/drivers/leds/leds-aw200xx.c
@@ -539,6 +539,10 @@ static int aw200xx_probe(struct i2c_client *client)
static void aw200xx_remove(struct i2c_client *client)
{
struct aw200xx *chip = i2c_get_clientdata(client);
+ int i;
+
+ for (i = 0; i < chip->num_leds; i++)
+ devm_led_classdev_unregister(&client->dev, &chip->leds[i].cdev);
aw200xx_chip_reset(chip);
mutex_destroy(&chip->mutex);
--
2.38.4
Powered by blists - more mailing lists