linux-kernel - Re: [PATCH v9 01/20] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c84f0999-5de0-1161-4061-75aa2795d45a@gmail.com>
Date:   Wed, 25 Oct 2023 09:16:50 -0400
From:   John Clark <inindev@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Conor Dooley <conor@...nel.org>
Cc:     Minda Chen <minda.chen@...rfivetech.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-pci@...r.kernel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mason Huo <mason.huo@...rfivetech.com>,
        Leyfoon Tan <leyfoon.tan@...rfivetech.com>,
        Kevin Xie <kevin.xie@...rfivetech.com>
Subject: Re: [PATCH v9 01/20] dt-bindings: PCI: Add PLDA XpressRICH PCIe host
 common properties

That is correct, I tested the entire series against Linux 6.6-rc7 and 
confirmed that pcie/nvme/usb work on the VisionFive2 device. I was 
unable to test the Microchip side of the equation. I will be more clear 
as to what I verified if I comment in the future.

John Clark


On 10/25/23 6:41 AM, Krzysztof Kozlowski wrote:
> On 25/10/2023 12:28, Conor Dooley wrote:
>> Hi John,
>>
>> On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
>>>> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>>>>> On 20/10/2023 12:43, Minda Chen wrote:
>>>>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>>>>> Microchip PolarFire PCIe host using PLDA IP.
>>>>>> Move common properties from Microchip PolarFire PCIe host
>>>>>> to PLDA files.
>>>>>>
>>>>>> Signed-off-by: Minda Chen <minda.chen@...rfivetech.com>
>>>>>> Reviewed-by: Hal Feng <hal.feng@...rfivetech.com>
>>>>>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>>>>>> Reviewed-by: Rob Herring <robh@...nel.org>
>>>>>> ---
>>>>>>    .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>>>>>    .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
>>>>> Where was this patch reviewed?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/20230727103949.26149-2-minda.chen@starfivetech.com/
>>>> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/20230814082016.104181-2-minda.chen@starfivetech.com/
>>> Tested-by: John Clark <inindev@...il.com>:
>>> https://github.com/inindev/visionfive2/tree/main/kernel/patches
>> I suspect you don't mean that you tested this individual dt-binding, but
>> rather that you tested the whole series. If so, you should probably
>> provide this tested-by against the cover-letter instead of this bindings
>> patch.
> Yeah, otherwise I would like to hear how do you test bindings (other
> than dt_binding_check which is something similar to testing as compiling
> code).
>
> Best regards,
> Krzysztof
>