linux-kernel - Re: upcoming merge window: Re: linux-next: manual merge of the vfs-brauner tree with the btrfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231025-braumeister-sprung-44d486e2d721@brauner>
Date:   Wed, 25 Oct 2023 15:19:05 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     David Sterba <dsterba@...e.cz>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>
Subject: Re: upcoming merge window: Re: linux-next: manual merge of the
 vfs-brauner tree with the btrfs tree

On Tue, Oct 24, 2023 at 05:46:20PM +0200, David Sterba wrote:
> On Tue, Oct 24, 2023 at 10:59:39AM +0200, Christian Brauner wrote:
> > On Tue, Oct 24, 2023 at 08:25:43AM +1100, Stephen Rothwell wrote:
> > > Hi David,
> > > 
> > > On Mon, 23 Oct 2023 19:55:13 +0200 David Sterba <dsterba@...e.cz> wrote:
> > > >
> > > > I have updated my for-next branch again, sorry (top commit 1a4dc97c883a4f763cbaf50).
> > > > There are some fixes I don't want to miss from the 6.7 pull request.
> > > > There should be minimal change to the VFS tree conflict resolution so
> > > > the diff should be reusable.
> > > 
> > > So, why did you not just merge in v6.6-rc7 (or better yet, the branch
> > > that contains the fix(es) that Linus merged) and then apply your new
> > > commits on top of that?  All the commits that were in the btrfs tree
> > > have been rebased unchanged.
> > 
> > Please reconsider that and follow Stephen's suggestion. I'm sending pull
> > requests this week and it'd be really annoying having to rebase
> > vfs.super right before sending them.
> > 
> > We let you carry the required patches in btrfs on your insistence even
> > though this effectively blocked two patchsets for a whole cycle
> 
> I hope I explained my reasons already under that series, core btrfs
> changes should not go via VFS tree.
> 
> > and then
> > merged in btrfs into vfs.super for that. Rebasing on such short notice
> > is really not very nice.
> 
> Like said in the my other reply, the amount of VFS changes asks for
> stopping taking new patches to btrfs and not continuing the patch
> workflow that I've been doing. I understand that the inter-tree
> dependencies are never easy so it's about finding some common way and
> splitting the work over more releases eventually.
> 
> A resync of our branches a week before merge window, when there are no

Pull requests for VFS and a bunch of other trees are going out the week
before the merge window opens. This has been requested multiple times.
It's mentioned in almost every kernel release mail that pull requests
should go out early.

So you rebasing a week before the merge window means rebasing
right before the pr is sent for us. You might send pull requests later
and are free to do so of course but you made us depend on your tree so
we need some stability. That's why the rebase is problematic here.

> significant changes on my side does not sound like too short notice, but
> you can feel otherwise of course.
> 
> > I'm going to wait with the rebase for a bit.
> 
> Ok, don't rebase. I'll push to linux-next the previous snapshot and will
> find a way how to deliver the new patches.

Thanks! So I know you have your workflow and that's obviously fine but
rebasing when other major trees depend on your tree is a problem and I
believe Stephen has already linked to our official "Rebasing and
merging" documentation:

"- Do not reparent a tree without a good reason to do so.  Just being on a
   newer base or avoiding a merge with an upstream repository is not
   generally a good reason."

[...]

"A frequent cause of merge-window trouble is when Linus is presented with a
patch series that has clearly been reparented, often to a random commit,
shortly before the pull request was sent.  The chances of such a series
having been adequately tested are relatively low - as are the chances of
the pull request being acted upon."

So I'll make sure to point out that we're depending on the btrfs tree
and I have a clear merge commit explaining why we're pulling it in. All
of that would be invalidated if you're rebasing. So not rebasing really
helps us a lot.

I specifically put Linus in Cc so hopefully everyone is aware up front
and there are no unnecessary suprises during the merge window.