linux-kernel - Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SC8380XP SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2023 15:50:22 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
        djakov@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     agross@...nel.org, conor+dt@...nel.org, quic_rjendra@...cinc.com,
        abel.vesa@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_tsoni@...cinc.com,
        neil.armstrong@...aro.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SC8380XP SoC

On 25/10/2023 15:40, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@...cinc.com>
> 
> The Qualcomm SC8380XP SoC has several bus fabrics that could be controlled
> and tuned dynamically according to the bandwidth demand.


...

> +  reg:
> +    maxItems: 1
> +
> +allOf:
> +  - $ref: qcom,rpmh-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,sc8380xp-clk-virt
> +              - qcom,sc8380xp-mc-virt
> +    then:
> +      properties:
> +        reg: false
> +    else:
> +      required:
> +        - reg
> +
> +required:
> +  - compatible

By convention we put required: block before allOf: and that's what
existing recent code has (qcom,sc8280xp-rpmh.yaml or
qcom,sc7280-rpmh.yaml' for example). Please use recent files as a
template for new bindings, so there will not be a need to fix the same
things again.

With fixes like in qcom,sc7280-rpmh.yaml:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

> +
> +unevaluatedProperties: false
Best regards,
Krzysztof