linux-kernel - [PATCH] firmware: xilinx: Move EXPORT_SYMBOL_GPL next to zynqmp_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 00:53:58 +0530
From:   Radhey Shyam Pandey <radhey.shyam.pandey@....com>
To:     <michal.simek@....com>, <gregkh@...uxfoundation.org>,
        <linus.walleij@...aro.org>, <tanmay.shah@....com>,
        <mathieu.poirier@...aro.org>, <nava.kishore.manne@....com>,
        <ben.levinsky@....com>, <roman.gushchin@...ux.dev>,
        <marex@...x.de>, <ronak.jain@...inx.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <git@....com>
Subject: [PATCH] firmware: xilinx: Move EXPORT_SYMBOL_GPL next to zynqmp_pm_feature definition

From: Rajan Vaja <rajan.vaja@...inx.com>

As mentioned in Documentation/process/coding-style.rst:
In source files, separate functions with one blank line. If the function
is exported, the **EXPORT** macro for it should follow immediately after
the closing function brace line.

So inline with guideline move zynqmp_pm_feature export symbol after its
definition.

Fixes: 218f01a80aea ("firmware: xilinx: always check API version for IOCTL/QUERY")
Signed-off-by: Rajan Vaja <rajan.vaja@...inx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
---
 drivers/firmware/xilinx/zynqmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index 4cc1ac7f76ed..b0d22d4455d9 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -226,7 +226,6 @@ static int do_feature_check_call(const u32 api_id)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(zynqmp_pm_feature);
 
 /**
  * zynqmp_pm_feature() - Check whether given feature is supported or not and
@@ -246,6 +245,7 @@ int zynqmp_pm_feature(const u32 api_id)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(zynqmp_pm_feature);
 
 /**
  * zynqmp_pm_is_function_supported() - Check whether given IOCTL/QUERY function
-- 
2.34.1