lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZTrF27Wm3v0Nn4IA@HP-ENVY-Notebook>
Date:   Thu, 26 Oct 2023 22:02:35 +0200
From:   Jonathan Bergh <bergh.jonathan@...il.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction
 of new typedefs

On Mon, Oct 23, 2023 at 05:41:38PM +0300, Dan Carpenter wrote:
> On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> > This patch series fixes (removes) the introduction of several new typedefs
> > for enums and structs in the octeon driver. First the declarations are
> > fixed and then implementations are updated to remove references to the 
> > old typedefs.
> > 
> > Changelog:
> >  * v1 -> v2: Fix breaking change spread across multiple patches
> >  * v2 -> v3: Break changes up into individual patches for each removed
> >    typedef
> > 
> > Jonathan Bergh (7):
> >   staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
> >     in octeon
> >   staging: octeon: Fix up introduction of new typedef
> >     cvmx_helper_interface_mode_t  in octeon
> >   staging: octeon: Fix introduction of following new typedef
> >     cvmx_pow_wait_t in octeon
> >   staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pip_port_status_t in octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pko_port_status_t in octeon driver
> > 
> >  drivers/staging/octeon/ethernet.c     |  6 ++--
> >  drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------

Hi
 
> Please don't change the stubs without change the arch/ code.

My tree was out of date, so these changes had already actually been applied
by basically the same patches (ie removing these typedefs) around 17/09 
(Sep).
 
> regards,
> dan carpenter
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ