lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZTrIoaFE+c5XQXFs@smile.fi.intel.com>
Date:   Thu, 26 Oct 2023 23:14:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     catalin.marinas@....com, will@...nel.org, pcc@...gle.com,
        andreyknvl@...il.com, aleksander.lobakin@...el.com,
        linux@...musvillemoes.dk, yury.norov@...il.com,
        alexandru.elisei@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, eugenis@...gle.com,
        syednwaris@...il.com, william.gray@...aro.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v10 1/2] lib/bitmap: add bitmap_{read,write}()

On Thu, Oct 26, 2023 at 04:48:46PM +0200, Alexander Potapenko wrote:

...

> > > +static inline void bitmap_write(unsigned long *map,
> > > +                             unsigned long value,
> > > +                             unsigned long start, unsigned long nbits)
> >
> > While noticing strange indentation (you have space for the parameter on
> > the previous line,
> 
> I believe I do not, maybe that's something on your side?
> There are tabs in the source, and in the original email.

I meant that you can use 2 lines instead of 3:

static inline void bitmap_write(unsigned long *map, unsigned long value,
				unsigned long start, unsigned long nbits)

> > I realized that this is a counter-intuitive interface.
> > Can you actually make value the last parameter?
> 
> It is consistent with bitmap_set_value8(map, value, start), and in all
> the functions above @nbits is the last parameter.

Oh, then I leave this to Yury.

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ