linux-kernel - Re: [PATCH bpf-next v2 0/2] selftests/bpf: Replaces CHECK macros and adds malloc failure checks to bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563d1ae7-8d1f-48d5-b742-989ce482c4f1@gmail.com>
Date:   Wed, 25 Oct 2023 21:37:44 -0700
From:   Kui-Feng Lee <sinquersw@...il.com>
To:     Yuran Pereira <yuran.pereira@...mail.com>, bpf@...r.kernel.org,
        yonghong.song@...ux.dev
Cc:     shuah@...nel.org, ast@...nel.org, daniel@...earbox.net,
        song@...nel.org, john.fastabend@...il.com, kpsingh@...nel.org,
        sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
        mykolal@...com, brauner@...nel.org, iii@...ux.ibm.com,
        kuifeng@...a.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 0/2] selftests/bpf: Replaces CHECK macros and
 adds malloc failure checks to bpf_iter



On 10/25/23 19:03, Yuran Pereira wrote:
> This patch series contains the following updates:
> - Replaces the usage of all the CHECK macros in bpf_iter
>    to the appropriate ASSERT_* macro calls
> - Adds appropriate malloc failure checks to bpf_iter
> 
> Changes in v2:
> - Removed unused "duration" variable which caused compilation error
>    as reported by Yonghong Song [1]
> - Improved malloc failure handling as suggested by Kui-Feng Lee [2]
> - Ensured propper patch formatting (i.e. sending it as a set instead
>    of two distinct patches)
> 
> [1] https://lore.kernel.org/lkml/3531360b-c933-4c5f-a84c-17edf0592519@linux.dev/
> [2] https://lore.kernel.org/lkml/7d703c4c-1a24-4806-a483-c02efb666059@gmail.com
> 
> 
> Previous version:
> v1 - https://lore.kernel.org/lkml/DB3PR10MB683589A5F705C6CA5BE0D325E8DFA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM
>     - https://lore.kernel.org/lkml/DB3PR10MB68356D7CDF6005480BE5876CE8DEA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM
> 
> Yuran Pereira (2):
>    selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter
>    selftests/bpf: Add malloc failure checks in bpf_iter
> 
>   .../selftests/bpf/prog_tests/bpf_iter.c       | 88 +++++++++----------
>   1 file changed, 44 insertions(+), 44 deletions(-)
> 


For the cover letter, you can just put it at the same directory of
patch 1 and 2 and sent them with "git send-email" at once. All of them
will be in the same thread.

"git format-patch --cover-letter ..." will generate a template
of the cover letter along with patches. FYI