linux-kernel - Re: [RFT PATCH 05/17] ASoC: codecs: max9867: Handle component name prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65d6ffc4c7bd6ce0ae75f7fb7d1f622467bfe9a7.camel@gmail.com>
Date:   Thu, 26 Oct 2023 07:42:22 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Nuno Sá <nuno.sa@...log.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-tegra@...r.kernel.org
Subject: Re: [RFT PATCH 05/17] ASoC: codecs: max9867: Handle component name
 prefix

On Mon, 2023-10-23 at 11:54 +0200, Krzysztof Kozlowski wrote:
> Use snd_soc_dapm_widget_name_cmp() helper when comparing widget names,
> to include also the component's name prefix.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  sound/soc/codecs/max9867.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
> index b616ad39858c..3b9dd158c34b 100644
> --- a/sound/soc/codecs/max9867.c
> +++ b/sound/soc/codecs/max9867.c
> @@ -56,13 +56,13 @@ static int max9867_adc_dac_event(struct snd_soc_dapm_widget *w,
>         struct max9867_priv *max9867 = snd_soc_component_get_drvdata(component);
>         enum max9867_adc_dac adc_dac;
>  
> -       if (!strcmp(w->name, "ADCL"))
> +       if (!snd_soc_dapm_widget_name_cmp(w, "ADCL"))
>                 adc_dac = MAX9867_ADC_LEFT;
> -       else if (!strcmp(w->name, "ADCR"))
> +       else if (!snd_soc_dapm_widget_name_cmp(w, "ADCR"))
>                 adc_dac = MAX9867_ADC_RIGHT;
> -       else if (!strcmp(w->name, "DACL"))
> +       else if (!snd_soc_dapm_widget_name_cmp(w, "DACL"))
>                 adc_dac = MAX9867_DAC_LEFT;
> -       else if (!strcmp(w->name, "DACR"))
> +       else if (!snd_soc_dapm_widget_name_cmp(w, "DACR"))
>                 adc_dac = MAX9867_DAC_RIGHT;
>         else
>                 return 0;