linux-kernel - Re: [PATCH] zswap: export compression failure stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231026070639.GB15694@google.com>
Date:   Thu, 26 Oct 2023 16:06:39 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Nhat Pham <nphamcs@...il.com>
Cc:     akpm@...ux-foundation.org, hannes@...xchg.org,
        cerasuolodomenico@...il.com, yosryahmed@...gle.com,
        sjenning@...hat.com, ddstreet@...e.org, vitaly.wool@...sulko.com,
        mhocko@...nel.org, roman.gushchin@...ux.dev, shakeelb@...gle.com,
        muchun.song@...ux.dev, linux-mm@...ck.org, kernel-team@...a.com,
        linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH] zswap: export compression failure stats

On (23/10/24 16:45), Nhat Pham wrote:
> 
> During a zswap store attempt, the compression algorithm could fail (for
> e.g due to the page containing incompressible random data). This is not
> tracked in any of existing zswap counters, making it hard to monitor for
> and investigate. We have run into this problem several times in our
> internal investigations on zswap store failures.
> 
> This patch adds a dedicated debugfs counter for compression algorithm
> failures.
> 
> Signed-off-by: Nhat Pham <nphamcs@...il.com>

FWIW,
Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>