linux-kernel - Re: [PATCH 1/7] RAS: Add Address Translation support for MI200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202310261444.Z20oGCyr-lkp@intel.com>
Date:   Thu, 26 Oct 2023 16:44:44 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Muralidhara M K <muralimk@....com>, <linux-edac@...r.kernel.org>,
        <x86@...nel.org>
CC:     <oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <bp@...en8.de>, <mchehab@...nel.org>,
        Muralidhara M K <muralidhara.mk@....com>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH 1/7] RAS: Add Address Translation support for MI200

Hi Muralidhara,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ras/edac-for-next]
[also build test WARNING on tip/master linus/master tip/auto-latest v6.6-rc7 next-20231025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Muralidhara-M-K/RAS-Add-Address-Translation-support-for-MI200/20231025-154756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
patch link:    https://lore.kernel.org/r/20231025073339.630093-2-muralimk%40amd.com
patch subject: [PATCH 1/7] RAS: Add Address Translation support for MI200
config: x86_64-randconfig-071-20231026 (https://download.01.org/0day-ci/archive/20231026/202310261444.Z20oGCyr-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310261444.Z20oGCyr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@...el.com>
| Closes: https://lore.kernel.org/r/202310261444.Z20oGCyr-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/ras/amd/atl/map.c:416:5: warning: no previous prototype for 'get_umc_to_cs_mapping' [-Wmissing-prototypes]
     416 | int get_umc_to_cs_mapping(struct addr_ctx *ctx)
         |     ^~~~~~~~~~~~~~~~~~~~~


vim +/get_umc_to_cs_mapping +416 drivers/ras/amd/atl/map.c

ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  403  
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  404  /* UMC to CS mapping for MI200 die[0]s */
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  405  u8 umc_to_cs_mapping_mi200_die0[] = { 28, 20, 24, 16, 12, 4, 8, 0,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  406  					6, 30, 2, 26, 22, 14, 18, 10,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  407  					19, 11, 15, 7, 3, 27, 31, 23,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  408  					9, 1, 5, 29, 25, 17, 21, 13};
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  409  
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  410  /* UMC to CS mapping for MI200 die[1]s */
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  411  u8 umc_to_cs_mapping_mi200_die1[] = { 19, 11, 15, 7, 3, 27, 31, 23,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  412  					9, 1, 5, 29, 25, 17, 21, 13,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  413  					28, 20, 24, 16, 12, 4, 8, 0,
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  414  					6, 30, 2, 26, 22, 14, 18, 10};
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  415  
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25 @416  int get_umc_to_cs_mapping(struct addr_ctx *ctx)
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  417  {
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  418  	if (ctx->inst_id >= sizeof(umc_to_cs_mapping_mi200_die0))
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  419  		return -EINVAL;
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  420  
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  421  	/*
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  422  	 * MI200 has 2 dies and are enumerated alternatively
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  423  	 * die0's are enumerated as node 2, 4, 6 and 8
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  424  	 * die1's are enumerated as node 1, 3, 5 and 7
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  425  	 */
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  426  	if (ctx->node_id % 2)
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  427  		ctx->inst_id = umc_to_cs_mapping_mi200_die1[ctx->inst_id];
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  428  	else
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  429  		ctx->inst_id = umc_to_cs_mapping_mi200_die0[ctx->inst_id];
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  430  
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  431  	return 0;
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  432  }
ea0e1d9c3eaf5d Muralidhara M K 2023-10-25  433  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki