linux-kernel - Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get state for XPCS drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTosrAStdie0T+8n@shell.armlinux.org.uk>
Date:   Thu, 26 Oct 2023 10:09:00 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, andrew@...n.ch,
        Jose.Abreu@...opsys.com, fancer.lancer@...il.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get
 state for XPCS drivers

On Thu, Oct 26, 2023 at 11:13:05AM +0530, Raju Lakkaraju wrote:
> Add DW_2500BASEX case in xpcs_get_state( ) to update speed, duplex and pause
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> ---
> Change List:
> ============
> V0 -> V1:
>   - Remove the auto-negotiation check due to currently the DW_2500BASEX mode 
>     doesn't imply any auto-negotiation 

So I just thought why hadn't I picked up on the link-down code setting
->speed, ->duplex and ->pause in the previous patch. Looking back at
what you call V0, which I guess is:

https://lore.kernel.org/r/20230925075142.266026-1-Raju.Lakkaraju@microchip.com

it's because the code wasn't there, and neither is its addition listed
in the above change list. That makes the change list rather misleading.

If you're going to provide a list of changes, please ensure it
describes all the changes from the previous iteration, or don't bother
including a list of changes. No list of changes is better than an
incomplete and thus misleading list of changes.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!