[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f3661605-ea2f-4681-8486-b83bd042568c@linaro.org>
Date: Thu, 26 Oct 2023 12:36:49 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
catalin.marinas@....com, ulf.hansson@...aro.org
Cc: agross@...nel.org, conor+dt@...nel.org, ayan.kumar.halder@....com,
j@...nau.net, dmitry.baryshkov@...aro.org, nfraprado@...labora.com,
m.szyprowski@...sung.com, u-kumar1@...com, peng.fan@....com,
lpieralisi@...nel.org, quic_rjendra@...cinc.com,
abel.vesa@...aro.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, quic_tsoni@...cinc.com,
neil.armstrong@...aro.org
Subject: Re: [PATCH 3/5] arm64: dts: qcom: Add base SC8380XP dtsi and the QCP
dts
On 10/25/23 16:24, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@...cinc.com>
>
> Add base dtsi and QCP board (Qualcomm Compute Platform) dts file for
> SC8380XP SoC, describing the CPUs, GCC and RPMHCC clock controllers,
> geni UART, interrupt controller, TLMM, reserved memory, interconnects,
> SMMU and LLCC nodes.
>
> Co-developed-by: Abel Vesa <abel.vesa@...aro.org>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> Signed-off-by: Rajendra Nayak <quic_rjendra@...cinc.com>
> Co-developed-by: Sibi Sankar <quic_sibis@...cinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---
[...]
> +&tlmm {
> + gpio-reserved-ranges = <33 3>, <44 4>, <238 1>;
It would be really cool if you added an explanation on why these
GPIOs need to be reserved, especially since you can see what's
connected on there on schematics. So, like:
gpio-reserved-ranges = <33 3>, /* something */
<44 4>, /* something else (fp scanner?)
<238 1>; /* UFS reset? */
[...]
> + compatible = "qcom,oryon";
Again, this compatible won't fly unless all of these cores
are totally identical and Oryon is only a name for this
generation on this SoC (which I believe not to be the case).
> + reg = <0x0 0x0>;
> + enable-method = "psci";
> + next-level-cache = <&L1_0>;
> +
> + L1_0: l1-cache {
> + compatible = "cache";
I'm not sure if L1 is supposed to be described in the DT,
Krzysztof should know.
> + next-level-cache = <&L2_0>;
> +
> + L2_0: l2-cache-0 {
> + compatible = "cache";
cache-level?
cache-unified?
[...]
> + memory@...00000 {
> + device_type = "memory";
> + /* We expect the bootloader to fill in the size */
> + reg = <0 0x80000000 0 0x80000000>;
That contradicts the comment you made above. Plus, 2 GiB seems a
bit low for this SoC :D
[...]
> + gunyah_hyp_mem: gunyah-hyp-region@...00000 {
you can probably strip the "-region" part, as this is implied by
being a child of /reserved-memory
> + pld_pep_mem: pld-pep-region@...30000 {
What's PLD?
What's this region used for? PEP is a Windows invention.
[...]
> + av1_encoder_mem: av1-encoder-region@...00000 {
Is AV1enc hardware separate from iris?
[...]
> + gcc: clock-controller@...000 {
> + compatible = "qcom,sc8380xp-gcc";
> + reg = <0 0x100000 0 0x200000>;
The address part of reg should be padded to 8 hex digits.
> +
> + interconnects = <&clk_virt MASTER_QUP_CORE_2 0 &clk_virt SLAVE_QUP_CORE_2 0>,
QCOM_ICC_TAG_ALWAYS would be nicer than 0 (see sa8775p)
[...]
> +
> + interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
One space after and before '='
Konrad
Powered by blists - more mailing lists