linux-kernel - Re: [PATCH V2] nvmem: brcm_nvram: store a copy of NVRAM content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202310261904.cWDKcVh8-lkp@intel.com>
Date:   Thu, 26 Oct 2023 19:31:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        Arınç ÜNAL <arinc.unal@...nc9.com>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Scott Branden <scott.branden@...adcom.com>
Subject: Re: [PATCH V2] nvmem: brcm_nvram: store a copy of NVRAM content

Hi Rafał,

kernel test robot noticed the following build warnings:

[auto build test WARNING on soc/for-next]
[also build test WARNING on linus/master v6.6-rc7 next-20231026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rafa-Mi-ecki/nvmem-brcm_nvram-store-a-copy-of-NVRAM-content/20231026-153630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link:    https://lore.kernel.org/r/20231026073440.6724-1-zajec5%40gmail.com
patch subject: [PATCH V2] nvmem: brcm_nvram: store a copy of NVRAM content
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231026/202310261904.cWDKcVh8-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310261904.cWDKcVh8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310261904.cWDKcVh8-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/nvmem/brcm_nvram.c:36: warning: Function parameter or member 'dev' not described in 'brcm_nvram'
>> drivers/nvmem/brcm_nvram.c:36: warning: Function parameter or member 'cells' not described in 'brcm_nvram'
>> drivers/nvmem/brcm_nvram.c:36: warning: Function parameter or member 'ncells' not described in 'brcm_nvram'


vim +36 drivers/nvmem/brcm_nvram.c

3fef9ed0627af3 Rafał Miłecki 2021-03-30  19  
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  20  /**
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  21   * struct brcm_nvram - driver state internal struct
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  22   *
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  23   * @nvmem_size:		Size of the whole space available for NVRAM
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  24   * @data:		NVRAM data copy stored to avoid poking underlaying flash controller
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  25   * @data_len:		NVRAM data size
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  26   * @padding_byte:	Padding value used to fill remaining space
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  27   */
3fef9ed0627af3 Rafał Miłecki 2021-03-30  28  struct brcm_nvram {
3fef9ed0627af3 Rafał Miłecki 2021-03-30  29  	struct device *dev;
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  30  	size_t nvmem_size;
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  31  	uint8_t *data;
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  32  	size_t data_len;
6bb6c90c7bc5bb Rafał Miłecki 2023-10-26  33  	uint8_t padding_byte;
6e977eaa8280e9 Rafał Miłecki 2022-02-25  34  	struct nvmem_cell_info *cells;
6e977eaa8280e9 Rafał Miłecki 2022-02-25  35  	int ncells;
6e977eaa8280e9 Rafał Miłecki 2022-02-25 @36  };
6e977eaa8280e9 Rafał Miłecki 2022-02-25  37  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki