[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CWIFPP04TD0A.G0Q3H51W9E9S@tleb-bootlin-xps13-01>
Date: Thu, 26 Oct 2023 16:18:45 +0200
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Linus Walleij" <linus.walleij@...aro.org>
Cc: "Russell King" <linux@...linux.org.uk>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Jiri Slaby" <jirislaby@...nel.org>,
<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
"Gregory CLEMENT" <gregory.clement@...tlin.com>,
"Alexandre Belloni" <alexandre.belloni@...tlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@...ileye.com>,
"Tawfik Bayouk" <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH 6/6] tty: serial: amba-pl011: Parse bits option as 5, 6,
7 or 8 in _get_options
Hello,
On Thu Oct 26, 2023 at 3:48 PM CEST, Linus Walleij wrote:
> On Thu, Oct 26, 2023 at 12:41 PM Théo Lebrun <theo.lebrun@...tlin.com> wrote:
>
> > pl011_console_get_options() gets called to retrieve currently configured
> > options from the registers. Previously, LCRH_TX.WLEN was being parsed
> > as either 7 or 8 (fallback). Hardware supports values from 5 to 8
> > inclusive, which pl011_set_termios() exploits for example.
> >
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
>
> With Ilpo's comment fixed:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
It's been fixed locally. Thank you for your review Linus!
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists