linux-kernel - Re: [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 17:00:17 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     syed saba kareem <ssabakar@....com>
Cc:     Syed Saba Kareem <Syed.SabaKareem@....com>, broonie@...nel.org,
        alsa-devel@...a-project.org, Vijendar.Mukunda@....com,
        Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        mario.limonciello@....com, venkataprasad.potturu@....com,
        arungopal.kondaveeti@....com, mastan.katragadda@....com,
        juan.martinez@....com, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        V Sujith Kumar Reddy <vsujithkumar.reddy@....com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Jarkko Nikula <jarkko.nikula@...mer.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support

On Thu, 26 Oct 2023 at 12:09, syed saba kareem <ssabakar@....com> wrote:
> +
> +module_platform_driver(acp63_driver);
> +
> +MODULE_DESCRIPTION("AMD ACP acp63 Driver");
> +MODULE_IMPORT_NS(SND_SOC_ACP_COMMON);
> +MODULE_LICENSE("Dual BSD/GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);
>
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong.
>
> It is platform driver ,for auto loading MODULE_ALIAS() is required.

Hm, not really. platform_driver does not need MODULE_ALIAS(). At least
99% of them do not need it. Please help us understand what is broken
here that this one platform driver needs alias.

BR,
Krzysztof