[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ixs2dtrijaft4j5hnmemhxuq6mpvmlnv64t5nkge4olnnwrldk@bfjffg7ard5g>
Date: Wed, 25 Oct 2023 19:18:45 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Krishna chaitanya chundru <quic_krichai@...cinc.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>, mhi@...ts.linux.dev,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
quic_vbadigan@...cinc.com, quic_ramkri@...cinc.com,
quic_skananth@...cinc.com, quic_parass@...cinc.com
Subject: Re: [PATCH] bus: mhi: host: Add alignment check for event ring read
pointer
On Mon, Oct 23, 2023 at 03:13:06PM +0530, Krishna chaitanya chundru wrote:
> Though we do check the event ring read pointer by "is_valid_ring_ptr"
> to make sure it is in the buffer range, but there is another risk the
> pointer may be not aligned. Since we are expecting event ring elements
> are 128 bits(struct mhi_tre) aligned, an unaligned read pointer could lead
> to multiple issues like DoS or ring buffer memory corruption.
>
> So add a alignment check for event ring read pointer.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>
Reviewed-by: Bjorn Andersson <andersson@...nel.org>
Regards,
Bjorn
> ---
> drivers/bus/mhi/host/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index 499590437e9b..c907bbb67fb2 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -268,7 +268,7 @@ static void mhi_del_ring_element(struct mhi_controller *mhi_cntrl,
>
> static bool is_valid_ring_ptr(struct mhi_ring *ring, dma_addr_t addr)
> {
> - return addr >= ring->iommu_base && addr < ring->iommu_base + ring->len;
> + return addr >= ring->iommu_base && addr < ring->iommu_base + ring->len && addr % 16 == 0;
> }
>
> int mhi_destroy_device(struct device *dev, void *data)
>
> ---
> base-commit: 71e68e182e382e951d6248bccc3c960dcec5a718
> change-id: 20231013-alignment_check-c013f509d24a
>
> Best regards,
> --
> Krishna chaitanya chundru <quic_krichai@...cinc.com>
>
Powered by blists - more mailing lists