linux-kernel - Re: [PATCH v2] hwmon: (pmbus/max31785) Add delay between bus accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd996a28-99e6-ea69-df0e-49cf68780d16@roeck-us.net>
Date:   Thu, 26 Oct 2023 09:49:40 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Lakshmi Yadlapati <lakshmiy@...ibm.com>
Cc:     "joel@....id.au" <joel@....id.au>,
        "andrew@...id.au" <andrew@...id.au>,
        "eajames@...ux.ibm.com" <eajames@...ux.ibm.com>,
        "ninad@...ux.ibm.com" <ninad@...ux.ibm.com>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] hwmon: (pmbus/max31785) Add delay between bus accesses

On 10/26/23 07:48, Lakshmi Yadlapati wrote:
> Thank you Guenter!
> Should I fix and send the patch again?
> 

Please do. And don't top-post.

Thanks,
Guenter

> On 10/25/23, 7:48 PM, "Guenter Roeck" <groeck7@...il.com <mailto:groeck7@...il.com> on behalf of linux@...ck-us.net <mailto:linux@...ck-us.net>> wrote:
> 
> 
> On Mon, Oct 23, 2023 at 01:08:03PM -0500, Lakshmi Yadlapati wrote:
>> Changes since V1:
>> 1. Changed the max31785_wait macro to a function, following the conventions
>> used in other drivers that had the same issue.
>> 2. Changed the function names from max31785_i2c_smbus* to max31785_i2c_* and
>> from max31785_pmbus_* to _max31785_*, making them more concise.
>>
> 
> 
> Please check Documentation/process/submitting-patches.rst
> for the expected patch format, specifically details on how
> description and change log are supposed to look like.
> 
> 
> Guenter
> 
> 
>