linux-kernel - Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde tma_info_system_dram_bw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjRac8i9+VWYNfWxNr5iz3bUUxc0-Phfcbk0RdfwXqr6w@mail.gmail.com>
Date:   Thu, 26 Oct 2023 10:12:41 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Perry Taylor <perry.taylor@...el.com>,
        Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde
 tma_info_system_dram_bw_use metric

Hi Ian,

On Wed, Oct 25, 2023 at 9:20 PM Ian Rogers <irogers@...gle.com> wrote:
>
> On Wed, Oct 25, 2023 at 2:56 PM Ian Rogers <irogers@...gle.com> wrote:
> >
> > On Thu, Oct 5, 2023 at 3:16 PM Ian Rogers <irogers@...gle.com> wrote:
> > >
> > > On Wed, Sep 27, 2023 at 6:47 AM Liang, Kan <kan.liang@...ux.intel.com> wrote:
> > > >
> > > >
> > > >
> > > > On 2023-09-26 4:59 p.m., Ian Rogers wrote:
> > > > > Broadwell-de has a consumer core and server uncore. The uncore_arb PMU
> > > > > isn't present and the broadwellx style cbox PMU should be used
> > > > > instead. Fix the tma_info_system_dram_bw_use metric to use the server
> > > > > metric rather than client.
> > > > >
> > > > > The associated converter script fix is in:
> > > > > https://github.com/intel/perfmon/pull/111
> > > > >
> > > > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell variant events/metrics")
> > > > > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > > > > ---
> > > >
> > > > Thanks Ian. The whole patch series looks good to me.
> > > >
> > > > Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>
> > >
> > > Would be good to pick this up in perf-tools-next.
> > >
> > > Thanks,
> > > Ian
> >
> > Ping.
>
> Thanks Namhyung for picking this up. There were two other patches in
> the v2 patch set that Kan reviewed:
> https://lore.kernel.org/all/8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.intel.com/
> that I don't see in perf-tools-next.

Sorry about that.  I'll take care of them too.

Thanks,
Namhyung