linux-kernel - Re: [PATCH v2 1/2] KVM: VMX: Cleanup VMX basic information defines and usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 10:40:01 -0700
From:   Xin Li <xin@...or.com>
To:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     seanjc@...gle.com, pbonzini@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        x86@...nel.org, hpa@...or.com, weijiang.yang@...el.com
Subject: Re: [PATCH v2 1/2] KVM: VMX: Cleanup VMX basic information defines
 and usages

On 10/26/2023 10:25 AM, Xin Li (Intel) wrote:
> From: Xin Li <xin3.li@...el.com>
> 
> Define VMX basic information fields with BIT_ULL()/GENMASK_ULL(), and
> replace hardcoded VMX basic numbers with these macros.
> 
> Per Sean's ask, read MSR_IA32_VMX_BASIC into an u64 to get rid of the
> hi/lo crud.
> 
> Tested-by: Shan Kang <shan.kang@...el.com>
> Signed-off-by: Xin Li <xin3.li@...el.com>
> ---
> 
> Changes since v1:
> * Don't add field shift macros unless it's really needed, extra layer
>    of indirect makes it harder to read (Sean Christopherson).
> * Add a static_assert() to ensure that VMX_BASIC_FEATURES_MASK doesn't
>    overlap with VMX_BASIC_RESERVED_BITS (Sean Christopherson).
> * read MSR_IA32_VMX_BASIC into an u64 rather than 2 u32 (Sean
>    Christopherson).
> * Add 2 new functions for extracting fields from VMX basic (Sean
>    Christopherson).
> * Drop the tools header update (Sean Christopherson).
> * Move VMX basic field macros to arch/x86/include/asm/vmx.h.
> ---
>   arch/x86/include/asm/msr-index.h |  9 ---------
>   arch/x86/include/asm/vmx.h       | 16 ++++++++++++++++
>   arch/x86/kvm/vmx/nested.c        | 25 ++++++++++++++++++-------
>   arch/x86/kvm/vmx/vmx.c           | 22 ++++++++++------------
>   4 files changed, 44 insertions(+), 28 deletions(-)

Sigh, forgot to add "--base=HEAD~2".

This is based on commit c076acf10c78c0d7e1aa50670e9cc4c91e8d59b4 of the 
'next' branch in the kvm-x86 tree.

Thanks!
     Xin