[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fd686385-df67-4415-bb53-6d71194064b8@lunn.ch>
Date: Thu, 26 Oct 2023 19:44:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Elad Nachman <enachman@...vell.com>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, gregory.clement@...tlin.com,
sebastian.hesselbarth@...il.com, pali@...nel.org,
mrkiko.rs@...il.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
cyuval@...vell.com
Subject: Re: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x
rd carrier
On Thu, Oct 26, 2023 at 11:47:34AM +0300, Elad Nachman wrote:
> From: Elad Nachman <enachman@...vell.com>
>
> Add dt bindings for AC5X RD COM Express Type 7 carrier board.
> This board will Accept a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@...vell.com>
> ---
> .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 52d78521e412..71bc94047d1b 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -60,4 +60,12 @@ properties:
> - const: marvell,armada-ap807-quad
> - const: marvell,armada-ap807
>
> + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP
This description is i think technically wrong. You have the
combination of the carrier and the module.
> + items:
> + - const: marvell,ac5x_rd_carrier
> + - const: marvell,cn9131
> + - const: marvell,cn9130
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
Andrew
Powered by blists - more mailing lists