[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023102739-absolve-coastal-6b4d@gregkh>
Date: Fri, 27 Oct 2023 09:02:04 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Gairuboina Sirisha <sirisha.gairuboina@...s.com>
Cc: linux-kernel@...r.kernel.org, lee@...nel.org, arnd@...db.de
Subject: Re: [PATCH v1 1/3] drivers: mfd: Add support for TPS65224
On Thu, Oct 26, 2023 at 07:02:24PM +0530, Gairuboina Sirisha wrote:
> From: Gairuboina Sirisha <sirisha.gairuboina@...s.com>
>
> Added support for tps65224 driver pmic core, header, Makefile and Kconfig
What is a "tps65224"? Please provide some more information so we know
how to review this.
>
> Signed-off-by: Gairuboina Sirisha <sirisha.gairuboina@...s.com>
> ---
> drivers/mfd/Kconfig | 5 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65224-core.c | 291 ++++++++++++++
> include/linux/mfd/tps65224.h | 735 +++++++++++++++++++++++++++++++++++
> 4 files changed, 1032 insertions(+)
> create mode 100644 drivers/mfd/tps65224-core.c
> create mode 100644 include/linux/mfd/tps65224.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 90ce58fd629e..2e4906484eed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1767,6 +1767,11 @@ config MFD_TPS6594_SPI
>
> This driver can also be built as a module. If so, the module
> will be called tps6594-spi.
> +config MFD_TPS65224
You need a blank line before this, right?
> + tristate
> + select MFD_CORE
> + select REGMAP
> + select REGMAP_IRQ
No help text at all to describe what this is?
> --- /dev/null
> +++ b/drivers/mfd/tps65224-core.c
> @@ -0,0 +1,291 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Core functions for TI TPS65224 PMIC
> + *
> + * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
No changes have happened since 2015 to this code?
> +EXPORT_SYMBOL_GPL(tps65224_device_init);
> +
> +MODULE_AUTHOR("Gairuboina Sirisha <sirisha.gairuboina@...s.com>");
That dosn't match the copyright line :(
> --- /dev/null
> +++ b/include/linux/mfd/tps65224.h
Why do you need a .h file at all? This is just used in one .c file,
right?
thanks,
greg k-h
Powered by blists - more mailing lists