linux-kernel - Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023102709-purse-repressed-d8b9@gregkh>
Date:   Fri, 27 Oct 2023 09:07:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     Witold Baryluk <witold.baryluk@...il.com>, arnd@...nel.org,
        Larry.Finger@...inger.net, alexandre.belloni@...tlin.com,
        arnd@...db.de, claudiu.beznea@...on.dev, davem@...emloft.net,
        geert@...ux-m68k.org, geoff@...radead.org,
        gregory.greenman@...el.com, ilw@...ux.intel.com,
        johannes@...solutions.net, kuba@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-wireless@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, nicolas.ferre@...rochip.com,
        pavel@....cz, quic_jjohnson@...cinc.com, stas.yakovlev@...il.com,
        stf_xl@...pl
Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote:
> For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0',
> removing those is a good a start. Also converting the ugly debug_level
> procfs file to something more modern would be nice, maybe using just
> dev_dbg() throught the driver is a good option? Or maybe use a module
> parameter instead?

Ick, no new module parameters, this isn't the 1990's, please just use
the netdev debug lines instead :)

thanks,

greg k-h