linux-kernel - RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 07:36:45 +0000
From:   "Zhang, Tina" <tina.zhang@...el.com>
To:     Joerg Roedel <joro@...tes.org>
CC:     "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David Woodhouse" <dwmw2@...radead.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        "Will Deacon" <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Nicolin Chen <nicolinc@...dia.com>,
        Michael Shavit <mshavit@...gle.com>,
        Vasant Hegde <vasant.hegde@....com>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA

Hi Joerg,

> -----Original Message-----
> From: Joerg Roedel <joro@...tes.org>
> Sent: Friday, October 27, 2023 3:12 PM
> To: Zhang, Tina <tina.zhang@...el.com>
> Cc: iommu@...ts.linux.dev; linux-kernel@...r.kernel.org; David Woodhouse
> <dwmw2@...radead.org>; Lu Baolu <baolu.lu@...ux.intel.com>; Will Deacon
> <will@...nel.org>; Robin Murphy <robin.murphy@....com>; Jason
> Gunthorpe <jgg@...pe.ca>; Tian, Kevin <kevin.tian@...el.com>; Nicolin Chen
> <nicolinc@...dia.com>; Michael Shavit <mshavit@...gle.com>; Vasant
> Hegde <vasant.hegde@....com>; Jason Gunthorpe <jgg@...dia.com>
> Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
> 
> Hi Tina,
> 
> On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > From: Jason Gunthorpe <jgg@...dia.com>
> >
> > Linus suggested that the kconfig here is confusing:
> 
> While this patch looks decent to me, you forgot to Cc Linus on it. In general,
> given that it touches a couple of core files, I'd like to wait for some more
> people to have a look at it and not rushing anything in.
Make sense. I'll CC Linus. Comments are welcome.

> >
> > https://lore.kernel.org/all/CAHk-
> =wgUiAtiszwseM1p2fCJ+sC4XWQ+YN4TanFhU
> > gvUqjr9Xw@...l.gmail.com/
> >
> > Let's break it into three kconfigs controlling distinct things:
> >
> >  - CONFIG_IOMMU_MM_DATA controls if the mm_struct has the additional
> >    fields for the IOMMU. Currently only PASID, but later patches store
> >    a struct iommu_mm_data *
> >
> >  - CONFIG_ARCH_HAS_CPU_PASID controls if the arch needs the scheduling
> bit
> >    for keeping track of the ENQCMD instruction. x86 will select this if
> >    IOMMU_SVA is enabled
> >
> >  - IOMMU_SVA controls if the IOMMU core compiles in the SVA support
> code
> >    for iommu driver use and the IOMMU exported API
> >
> > This way ARM will not enable CONFIG_ARCH_HAS_CPU_PASID
> >
> > Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
> 
> If you send it, you also need to add your Signed-off-by.
OK. I'll add my Signed-off-by.

Thanks,
-Tina

> 
> Regards,
> 
> 	Joerg