linux-kernel - Re: [tip:x86/percpu 21/22] arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 27 Oct 2023 09:46:58 +0200
From:   Uros Bizjak <ubizjak@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        x86@...nel.org, Ingo Molnar <mingo@...nel.org>,
        Nadav Amit <namit@...are.com>
Subject: Re: [tip:x86/percpu 21/22] arch/x86/include/asm/processor.h:522:24:
 sparse: sparse: dereference of noderef expression

On Fri, Oct 27, 2023 at 4:01 AM kernel test robot <lkp@...el.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/percpu
> head:   0548eb067ed664b93043e033295ca71e3e706245
> commit: ed2f752e0e0a21d941ca0ee539ef3d4cd576bc5e [21/22] x86/percpu: Introduce const-qualified const_pcpu_hot to micro-optimize code generation
> config: x86_64-randconfig-122-20231027 (https://download.01.org/0day-ci/archive/20231027/202310270909.QBAOkiZP-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270909.QBAOkiZP-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310270909.QBAOkiZP-lkp@intel.com/

Already fixed in [1].

[1] https://lore.kernel.org/lkml/20231024142830.3226-1-ubizjak@gmail.com/

Thanks,
Uros.

>
> sparse warnings: (new ones prefixed by >>)
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through arch/x86/include/asm/cpufeature.h, arch/x86/include/asm/thread_info.h, include/linux/thread_info.h, ...):
> >> arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through arch/x86/include/asm/cpufeature.h, arch/x86/include/asm/thread_info.h, include/linux/thread_info.h, ...):
> >> arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through arch/x86/include/asm/cpufeature.h, arch/x86/include/asm/thread_info.h, include/linux/thread_info.h, ...):
> >> arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through arch/x86/include/asm/cpufeature.h, arch/x86/include/asm/thread_info.h, include/linux/thread_info.h, ...):
> >> arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through arch/x86/include/asm/cpufeature.h, arch/x86/include/asm/thread_info.h, include/linux/thread_info.h, ...):
> >> arch/x86/include/asm/processor.h:522:24: sparse: sparse: dereference of noderef expression
>    kernel/entry/common.c: note: in included file (through include/linux/sched.h, include/linux/context_tracking.h):
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>    arch/x86/include/asm/current.h:46:24: sparse: sparse: dereference of noderef expression
>
> vim +522 arch/x86/include/asm/processor.h
>
>    513
>    514  static __always_inline unsigned long current_top_of_stack(void)
>    515  {
>    516          /*
>    517           *  We can't read directly from tss.sp0: sp0 on x86_32 is special in
>    518           *  and around vm86 mode and sp0 on x86_64 is special because of the
>    519           *  entry trampoline.
>    520           */
>    521          if (IS_ENABLED(CONFIG_USE_X86_SEG_SUPPORT))
>  > 522                  return pcpu_hot.top_of_stack;
>    523
>    524          return this_cpu_read_stable(pcpu_hot.top_of_stack);
>    525  }
>    526
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki