[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f0e7a7f4-a34e-40cf-bd11-b648c28c5153@kernel.org>
Date: Fri, 27 Oct 2023 10:08:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gairuboina Sirisha <sirisha.gairuboina@...s.com>,
linux-kernel@...r.kernel.org
Cc: lee@...nel.org, arnd@...db.de, gregkh@...uxfoundation.org
Subject: Re: [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver
On 26/10/2023 15:32, Gairuboina Sirisha wrote:
> From: Gairuboina Sirisha <sirisha.gairuboina@...s.com>
>
> Added MFD driver that enables I2C communication with and without CRC
>
> Signed-off-by: Gairuboina Sirisha <sirisha.gairuboina@...s.com>
> ---
> drivers/mfd/Kconfig | 14 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65224-i2c.c | 245 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 260 insertions(+)
> create mode 100644 drivers/mfd/tps65224-i2c.c
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 2e4906484eed..943d85d49fc5 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1767,12 +1767,26 @@ config MFD_TPS6594_SPI
>
> This driver can also be built as a module. If so, the module
> will be called tps6594-spi.
> +
This does not belong to this patch.
> config MFD_TPS65224
> tristate
> select MFD_CORE
> select REGMAP
> select REGMAP_IRQ
...
}
> +
> +static const struct regmap_config tps65224_i2c_regmap_config = {
> + .reg_bits = 16,
> + .val_bits = 8,
> + .max_register = TPS65224_REG_WD_FAIL_CNT_REG,
> + .volatile_reg = tps65224_is_volatile_reg,
> + .read = tps65224_i2c_read,
> + .write = tps65224_i2c_write,
> +};
> +
> +static const struct of_device_id tps65224_i2c_of_match_table[] = {
> + { .compatible = "ti,tps65224-q1", },
Where is it documented? It seems nowhere, even though tools asked you to
do this. :(
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
Powered by blists - more mailing lists