linux-kernel - RE: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 08:25:06 +0000
From:   Ricky WU <ricky_wu@...ltek.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "frank.li@...o.com" <frank.li@...o.com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: RE: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264

> On Mon, Oct 23, 2023 at 03:31:24AM +0000, Ricky WU wrote:
> > > > In order to support new chip rts5264, the definitions of some
> > > > internal registers and workflow have to be modified.
> > >
> > > That is fine, but that should be a single patch, right?
> > >
> >
> > Sorry maybe about misunderstand, The modifications mentioned here, it
> > talk about some judgment expressions add "PID 5264" to make judgement
> > in rtsx_pcr.c, so only about 30 line modified in rtsx_pcr.c
> >
> > > > Added rts5264.c rts5264.h for independent functions of the new
> > > > chip rts5264
> > >
> > > And then add new support in a new patch, this is still too big as
> > > one patch to attempt to review it properly.  Would you like to
> > > review this as-is?
> > >
> >
> > Yes, thank you
> > Because rts5264.c rts5264.h only for rts5264 (new chip).
> > The past architecture of this driver was like this, and it will good
> > for us to maintain the driver different chip maybe has different
> > functions and register definitions we used to separate different .c .h
> 
> Sorry, I don't think I was clear, this needs to be broken up into smaller pieces to
> be able for us to review it properly.  Please do so and resend a new version of
> the patch series.
> 

Hi Greg k-h，

I want to confirm with you first
I will have a new version for this patch, separate it into:
1. 2 new file and Makefile for new chip function and definition 
2. rtsx_pcr.c and rtsx_pcr.h for driver judgement to call new chip function  
3. mmc part

It is ok for you?

Thank you
Ricky

> thanks,
> 
> greg k-h