linux-kernel - linux-next: manual merge of the integrity tree with the vfs-brauner tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20231027131137.3051da98@canb.auug.org.au>
Date:   Fri, 27 Oct 2023 13:11:37 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        Christian Brauner <brauner@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Mimi Zohar <zohar@...ux.ibm.com>
Subject: linux-next: manual merge of the integrity tree with the vfs-brauner
 tree

Hi all,

Today's linux-next merge of the integrity tree got a conflict in:

  fs/overlayfs/super.c

between commit:

  2bc5e5e8167f ("ovl: rely on SB_I_NOUMASK")

from the vfs-brauner tree and commit:

  bc4532e9cd3b ("ima: detect changes to the backing overlay file")

from the integrity tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/overlayfs/super.c
index 1a95ee237fa9,c71d185980c0..000000000000
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@@ -1439,18 -1485,11 +1439,18 @@@ int ovl_fill_super(struct super_block *
  	cap_lower(cred->cap_effective, CAP_SYS_RESOURCE);
  
  	sb->s_magic = OVERLAYFS_SUPER_MAGIC;
 -	sb->s_xattr = ofs->config.userxattr ? ovl_user_xattr_handlers :
 -		ovl_trusted_xattr_handlers;
 +	sb->s_xattr = ovl_xattr_handlers(ofs);
  	sb->s_fs_info = ofs;
 +#ifdef CONFIG_FS_POSIX_ACL
  	sb->s_flags |= SB_POSIXACL;
 +#endif
- 	sb->s_iflags |= SB_I_SKIP_SYNC | SB_I_IMA_UNVERIFIABLE_SIGNATURE;
+ 	sb->s_iflags |= SB_I_SKIP_SYNC;
 +	/*
 +	 * Ensure that umask handling is done by the filesystems used
 +	 * for the the upper layer instead of overlayfs as that would
 +	 * lead to unexpected results.
 +	 */
 +	sb->s_iflags |= SB_I_NOUMASK;
  
  	err = -ENOMEM;
  	root_dentry = ovl_get_root(sb, ctx->upper.dentry, oe);

Content of type "application/pgp-signature" skipped