linux-kernel - Re: [PATCH 2/2] tty: serial: 8250: Add support for MOXA PCIe boards to switch interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 18:10:47 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@...a.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/2] tty: serial: 8250: Add support for MOXA PCIe boards
 to switch interface

On Fri, Oct 27, 2023 at 10:29:38AM +0200, Jiri Slaby wrote:
> On 27. 10. 23, 8:24, Crescent CY Hsieh wrote:
> > MOXA PCIe boards have 4 serial interfaces and don't require additional
> > stuff to switch between interfaces:
> > 
> > - RS232
> > - RS422
> > - RS485_2W (half-duplex)
> > - RS485_4W (full-duplex)
> > 
> > By using ioctl command "TIOCRS485", it can switch between default
> > interface and RS485 if supported.
> > 
> > That means, for RS422/RS485 board, it can switch between RS422 and
> > RS485 by setting the flags within struct serial_rs485.
> > 
> > However, for the RS232/RS422/RS485 board, it can only switch between
> > RS232 and RS485, there's no flag for switching interface into RS422.
> > 
> > This patch adds a flag call "SER_RS422_ENALBED" in serial.h and modifies
> 
> It's not "ENALBED".
> 
> Anyway, I am afraid you have to split the patch into two:
> 1) add the flag and core support (but wait a bit for others if they agree
> with this approach)
> 2) add the support for moxa.

Agree, I will split this patch into two separate patches and only send
the patch for adding the flag and core support first.

---
Sincerely,
Crescent CY Hsieh