linux-kernel - Re: [PATCH V3 3/6] pinctrl: sprd: Move common and misc offset parameters to private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTud17B4VeASo0os@smile.fi.intel.com>
Date:   Fri, 27 Oct 2023 14:24:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Linhua Xu <Linhua.xu@...soc.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        lh xu <xulh0829@...il.com>,
        Zhirong Qiu <zhirong.qiu@...soc.com>,
        Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH V3 3/6] pinctrl: sprd: Move common and misc offset
 parameters to private data

On Fri, Oct 27, 2023 at 03:14:23PM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@...soc.com>
> 
> For UNISOC pin controller, the offset values of the common
> register and misc register will be different. So add SoC
> structure in sprd_pinctrl_of_match() and parse it in sprd-pinctrl_core.

...

> +	priv_data = of_device_get_match_data(&pdev->dev);
> +	if (!priv_data)
> +		return -EINVAL;

I believe there is the idea to make that API local to the device property core,
so use device_get_match_data() instead.

-- 
With Best Regards,
Andy Shevchenko