linux-kernel - Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTu8u3bgNCOhTx8U@kernel.org>
Date:   Fri, 27 Oct 2023 10:35:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Yang Jihong <yangjihong1@...wei.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, peterz@...radead.org,
        mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        irogers@...gle.com, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to
 rlimit__increase_nofile

Em Fri, Oct 27, 2023 at 10:43:32AM +0800, Yang Jihong escreveu:
> Sorry, only rename helper and no function change.
> I didn't consider the scenario that might affect test python.
 
> I've submitted a fix that can be used if needed:
 
> https://lore.kernel.org/lkml/20231027023028.1106441-1-yangjihong1@huawei.com/
 
> Also, can we consider identifying this problem at the stage of compiling the
> perf tool?

Yes, I have:

$ alias m='rm -rf ~/libexec/perf-core/ ; make -k CORESIGHT=1 O=/tmp/build/$(basename $PWD) -C tools/perf install-bin && perf test python'
 
And use the 'm' alias to build perf.

I also run 'perf test' before sending patches upstream, in addition to:

make -C tools/perf build-test

I encourage everybody to do the same.

Additionally I run a long list of container tests on dozens of distros,
but those should really be running on some CI system :-\

- Arnaldo