linux-kernel - Re: [PATCH v2 4/5] iio: pressure: bmp280: Allow multiple chips id per family of devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231027144625.36cc694c@jic23-huawei>
Date:   Fri, 27 Oct 2023 14:46:25 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-iio@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>,
        linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Phil Elwell <phil@...pberrypi.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2 4/5] iio: pressure: bmp280: Allow multiple chips id
 per family of devices

On Fri, 27 Oct 2023 14:42:34 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Mon, 23 Oct 2023 14:25:42 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > On Sun, Oct 22, 2023 at 07:22:20PM +0200, Angel Iglesias wrote:  
> > > Improve device detection in certain chip families known to have various
> > > chip ids.
> > > When no known ids match, gives a warning but follows along what device
> > > said on the firmware and tries to configure it.    
> > 
> > I would rephrase it a bit:
> > 
> > "Improve device detection in certain chip families known to have
> > various chip IDs. When no ID matches, give a warning but follow
> > along what device said on the firmware side and try to configure
> > it."
> > 
> > ...
> >   
> > > +	for (i = 0; i < data->chip_info->num_chip_id; i++) {
> > > +		if (chip_id == data->chip_info->chip_id[i]) {
> > > +			dev_info(dev, "0x%x is a known chip id for %s\n", chip_id, name);
> > > +			break;
> > > +		}    
> >   
> > > +		dev_warn(dev, "chip id 0x%x does not match known id 0x%x\n",
> > > +			 chip_id, data->chip_info->chip_id[i]);    
> > 
> > If the matching ID is not the first one, user will have an unneeded warning here.  
> 
> Could be a dev_dbg() but I'd just drop it entirely.
> 
Given that was all that came up, I've hopefully saved us all time by
dropping the bring and changing the patch description as Andy suggested.

With that done, applied.

Jonathan

> 
> >   
> > >  	}    
> >   
>