linux-kernel - Re: [PATCH 2/2] media: pci: mgb4: remove bogus 'select' statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 16:17:49 +0200
From:   Martin Tůma <tumic@...see.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Martin Tuma <martin.tuma@...iteqautomotive.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] media: pci: mgb4: remove bogus 'select' statements

Hi,

On 23. 10. 23 18:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> As this is just a regular device driver, it has no business force-enabling
> other drivers in the system, it should be entirely independent of the
> implementation of the spi-nor layer or the specific DMA engine.
> 

The drivers are required for IP cores that are used on the card (in the 
FPGA). Without I2C_XILINX and XILINX_XDMA the card won't work at all. 
Without SPI_XILINX the access to the card's FLASH (used e.g. for FW 
changes) won't be possible.

A change to "depend" instead of "select" is thus possible if it makes 
more sense to you, but removing it would make the module not compile or 
not work at runtime (there is no symbol dependency to I2C_XILINX and 
SPI_XILINX, but both need to be present and are loaded using 
request_module() at runtime).

M.

> The IIO symbols that are selected here are library modules that
> are legitimately used.
> 
> Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/media/pci/mgb4/Kconfig | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig
> index f2a05a1c8ffa..b90347c7f19b 100644
> --- a/drivers/media/pci/mgb4/Kconfig
> +++ b/drivers/media/pci/mgb4/Kconfig
> @@ -6,10 +6,6 @@ config VIDEO_MGB4
>   	select VIDEOBUF2_DMA_SG
>   	select IIO_BUFFER
>   	select IIO_TRIGGERED_BUFFER
> -	select I2C_XILINX
> -	select SPI_XILINX
> -	select MTD_SPI_NOR
> -	select XILINX_XDMA
>   	help
>   	  This is a video4linux driver for Digiteq Automotive MGB4 grabber
>   	  cards.