linux-kernel - Re: [PATCH] maple_tree: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 10:21:14 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] maple_tree: Remove unused function

* Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> [231027 04:50]:
> The function are defined in the maple_tree.c file, but not called
> elsewhere, so delete the unused function.
> 
> lib/maple_tree.c:689:29: warning: unused function 'mas_pivot'.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7064
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Thanks, this has fallen out of use and isn't used in the testing code
either.

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  lib/maple_tree.c | 29 -----------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index bb24d84a4922..cf889aaa0011 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -679,35 +679,6 @@ static inline unsigned long *ma_gaps(struct maple_node *node,
>  	return NULL;
>  }
>  
> -/*
> - * mas_pivot() - Get the pivot at @piv of the maple encoded node.
> - * @mas: The maple state.
> - * @piv: The pivot.
> - *
> - * Return: the pivot at @piv of @mn.
> - */
> -static inline unsigned long mas_pivot(struct ma_state *mas, unsigned char piv)
> -{
> -	struct maple_node *node = mas_mn(mas);
> -	enum maple_type type = mte_node_type(mas->node);
> -
> -	if (MAS_WARN_ON(mas, piv >= mt_pivots[type])) {
> -		mas_set_err(mas, -EIO);
> -		return 0;
> -	}
> -
> -	switch (type) {
> -	case maple_arange_64:
> -		return node->ma64.pivot[piv];
> -	case maple_range_64:
> -	case maple_leaf_64:
> -		return node->mr64.pivot[piv];
> -	case maple_dense:
> -		return 0;
> -	}
> -	return 0;
> -}
> -
>  /*
>   * mas_safe_pivot() - get the pivot at @piv or mas->max.
>   * @mas: The maple state
> -- 
> 2.20.1.7.g153144c
>