linux-kernel - Re: [PATCH] hwmon: (pmbus/mp2975) Move PGOOD fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b193df0c-dd41-4c6f-8e09-3bd9322dda8a@roeck-us.net>
Date:   Fri, 27 Oct 2023 07:27:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Naresh Solanki <naresh.solanki@...ements.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/mp2975) Move PGOOD fix

On Fri, Oct 27, 2023 at 10:33:52AM +0000, Naresh Solanki wrote:
> The PGOOD fix was intended for MP2973 & MP2971 & not for MP2975.
> 
> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>

Good catch. Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/mp2975.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> base-commit: 5421af83a43bdcb646564fec238253d11009ad3f
> 
> diff --git a/drivers/hwmon/pmbus/mp2975.c b/drivers/hwmon/pmbus/mp2975.c
> index 26ba50633100..b9bb469e2d8f 100644
> --- a/drivers/hwmon/pmbus/mp2975.c
> +++ b/drivers/hwmon/pmbus/mp2975.c
> @@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client *client, int page,
>  	int ret;
>  
>  	switch (reg) {
> +	case PMBUS_STATUS_WORD:
> +		/* MP2973 & MP2971 return PGOOD instead of PB_STATUS_POWER_GOOD_N. */
> +		ret = pmbus_read_word_data(client, page, phase, reg);
> +		ret ^= PB_STATUS_POWER_GOOD_N;
> +		break;
>  	case PMBUS_OT_FAULT_LIMIT:
>  		ret = mp2975_read_word_helper(client, page, phase, reg,
>  					      GENMASK(7, 0));
> @@ -380,11 +385,6 @@ static int mp2975_read_word_data(struct i2c_client *client, int page,
>  	int ret;
>  
>  	switch (reg) {
> -	case PMBUS_STATUS_WORD:
> -		/* MP2973 & MP2971 return PGOOD instead of PB_STATUS_POWER_GOOD_N. */
> -		ret = pmbus_read_word_data(client, page, phase, reg);
> -		ret ^= PB_STATUS_POWER_GOOD_N;
> -		break;
>  	case PMBUS_OT_FAULT_LIMIT:
>  		ret = mp2975_read_word_helper(client, page, phase, reg,
>  					      GENMASK(7, 0));