linux-kernel - Re: [PATCH v2] net: r8169: Disable multicast filter for RTL_GIGA_MAC_VER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <415e0355-7d71-4b82-b4fc-37dad22486a9@gmail.com>
Date:   Sat, 28 Oct 2023 10:38:43 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Patrick Thompson <ptf@...gle.com>, netdev@...r.kernel.org
Cc:     Chun-Hao Lin <hau@...ltek.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        nic_swsd@...ltek.com
Subject: Re: [PATCH v2] net: r8169: Disable multicast filter for
 RTL_GIGA_MAC_VER_46

On 27.10.2023 23:30, Patrick Thompson wrote:
> MAC_VER_46 ethernet adapters fail to detect eapol packets unless
> allmulti is enabled. Add exception for VER_46 in the same way VER_35
> has an exception.
> 
MAC_VER_48 (RTL8107E) has the same MAC, just a different PHY.
So I would expect that the same quirk is needed for MAC_VER_48.

MAC_VER_xx is a little misleading, actually it should be NIC_VER_xx

> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@...gle.com>
> ---
> 
> Changes in v2:
> - add Fixes tag
> - add net annotation
> - update description
> 
>  drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 361b90007148b..a775090650e3a 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -2584,7 +2584,8 @@ static void rtl_set_rx_mode(struct net_device *dev)
>  		rx_mode |= AcceptAllPhys;
>  	} else if (netdev_mc_count(dev) > MC_FILTER_LIMIT ||
>  		   dev->flags & IFF_ALLMULTI ||
> -		   tp->mac_version == RTL_GIGA_MAC_VER_35) {
> +		   tp->mac_version == RTL_GIGA_MAC_VER_35 ||
> +		   tp->mac_version == RTL_GIGA_MAC_VER_46) {
>  		/* accept all multicasts */
>  	} else if (netdev_mc_empty(dev)) {
>  		rx_mode &= ~AcceptMulticast;