linux-kernel - Re: [PATCH v12 01/20] cxl/port: Fix release of RCD endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <653c5691a2372_780ef2949b@dwillia2-xfh.jf.intel.com.notmuch>
Date:   Fri, 27 Oct 2023 17:32:17 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Robert Richter <rrichter@....com>,
        Dan Williams <dan.j.williams@...el.com>
CC:     Davidlohr Bueso <dave@...olabs.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "Alison Schofield" <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Terry Bowman" <terry.bowman@....com>
Subject: Re: [PATCH v12 01/20] cxl/port: Fix release of RCD endpoints

Robert Richter wrote:
> Dan,
[..]
> 
> delete_endpoint() is called here, but the uport etc. is not unbound.
> Which means this is not true:
> 
> 	if (parent->driver && !endpoint->dead) {
> 		...
> 
> I don't remember this with my patch. The parent is there different, so
> that could be the reason.
> 
> I could not yet look into more detail but wanted to let you know. Will
> continue.

Apologies, I didn't have that regression going, I think I see the issue.
Thanks for the heads up.