linux-kernel - Re: [PATCH v2] PM: sleep: Expose last succeeded resumed timestamp in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Oct 2023 21:37:38 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        oe-kbuild-all@...ts.linux.dev, suleiman@...gle.com,
        briannorris@...gle.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v2] PM: sleep: Expose last succeeded resumed timestamp
 in sysfs

On Sat, 28 Oct 2023 19:26:10 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Masami,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.6-rc7 next-20231027]
> [cannot apply to pavel-leds/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Masami-Hiramatsu-Google/PM-sleep-Expose-last-succeeded-resumed-timestamp-in-sysfs/20231028-093251
> base:   linus/master
> patch link:    https://lore.kernel.org/r/169845668624.1319505.1097714089024984847.stgit%40mhiramat.roam.corp.google.com
> patch subject: [PATCH v2] PM: sleep: Expose last succeeded resumed timestamp in sysfs
> config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20231028/202310281942.ZwkSMsVB-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231028/202310281942.ZwkSMsVB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310281942.ZwkSMsVB-lkp@intel.com/

Oops, I missed casting. Let me fix it.

Thanks,

> 
> All warnings (new ones prefixed by >>):
> 
>    kernel/power/main.c: In function 'last_success_resume_time_show':
> >> kernel/power/main.c:427:38: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'long int' [-Wformat=]
>      427 |         return sprintf(buf, "%llu.%llu\n",
>          |                                   ~~~^
>          |                                      |
>          |                                      long long unsigned int
>          |                                   %lu
>      428 |                        suspend_stats.last_success_resume_time.tv_sec,
>      429 |                        suspend_stats.last_success_resume_time.tv_nsec);
>          |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                                                              |
>          |                                                              long int
>    kernel/power/main.c: In function 'suspend_stats_show':
>    kernel/power/main.c:528:62: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'long int' [-Wformat=]
>      528 |         seq_printf(s,   "last_success_resume_time:\t%-llu.%llu\n",
>          |                                                           ~~~^
>          |                                                              |
>          |                                                              long long unsigned int
>          |                                                           %lu
>      529 |                    suspend_stats.last_success_resume_time.tv_sec,
>      530 |                    suspend_stats.last_success_resume_time.tv_nsec);
>          |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                                                          |
>          |                                                          long int
> 
> 
> vim +427 kernel/power/main.c
> 
>    423	
>    424	static ssize_t last_success_resume_time_show(struct kobject *kobj,
>    425			struct kobj_attribute *attr, char *buf)
>    426	{
>  > 427		return sprintf(buf, "%llu.%llu\n",
>    428			       suspend_stats.last_success_resume_time.tv_sec,
>    429			       suspend_stats.last_success_resume_time.tv_nsec);
>    430	}
>    431	static struct kobj_attribute last_success_resume_time =
>    432				__ATTR_RO(last_success_resume_time);
>    433	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>