linux-kernel - Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZT1ipfs3XzrKChmi@shikoro>
Date:   Sat, 28 Oct 2023 21:36:05 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Andi Shyti <andi.shyti@...nel.org>
Cc:     Samuel Holland <samuel.holland@...ive.com>,
        Peter Korsgaard <peter@...sgaard.com>,
        Andrew Lunn <andrew@...n.ch>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase


> > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> > the regmap-irq code must be able to perform I2C transactions during
> > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> > be suspended/resumed during the NOIRQ phase.
> > 
> > Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> 
> I think this patch has failed to receive some comments, I'll go
> ahead and give it my blessing:
> 
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

It needs to be rebased on top of 0ad93449b043 ("i2c: ocores: Remove
#ifdef guards for PM related functions"), though. This series did clean
this up for the whole subsystem. It also introduced using pm_sleep_ptr
which probably was missing here?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)