[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231028211518.3424020-2-da.gomez@samsung.com>
Date: Sat, 28 Oct 2023 21:15:35 +0000
From: Daniel Gomez <da.gomez@...sung.com>
To: "minchan@...nel.org" <minchan@...nel.org>,
"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
"axboe@...nel.dk" <axboe@...nel.dk>,
"djwong@...nel.org" <djwong@...nel.org>,
"willy@...radead.org" <willy@...radead.org>,
"hughd@...gle.com" <hughd@...gle.com>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"mcgrof@...nel.org" <mcgrof@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>
CC: "gost.dev@...sung.com" <gost.dev@...sung.com>,
Pankaj Raghav <p.raghav@...sung.com>,
Daniel Gomez <da.gomez@...sung.com>
Subject: [RFC PATCH 01/11] XArray: add cmpxchg order test
XArray multi-index entries do not keep track of the order stored once
the entry is being marked as used (replaced with NULL). Add a test
to check the order is actually lost.
Signed-off-by: Daniel Gomez <da.gomez@...sung.com>
Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>
---
lib/test_xarray.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/lib/test_xarray.c b/lib/test_xarray.c
index e77d4856442c..6c22588963bc 100644
--- a/lib/test_xarray.c
+++ b/lib/test_xarray.c
@@ -423,6 +423,26 @@ static noinline void check_cmpxchg(struct xarray *xa)
XA_BUG_ON(xa, !xa_empty(xa));
}
+static noinline void check_cmpxchg_order(struct xarray *xa)
+{
+ void *FIVE = xa_mk_value(5);
+ unsigned int order = IS_ENABLED(CONFIG_XARRAY_MULTI) ? 15 : 1;
+ void *old;
+
+ XA_BUG_ON(xa, !xa_empty(xa));
+ XA_BUG_ON(xa, xa_store_index(xa, 5, GFP_KERNEL) != NULL);
+ XA_BUG_ON(xa, xa_insert(xa, 5, FIVE, GFP_KERNEL) != -EBUSY);
+ XA_BUG_ON(xa, xa_store_order(xa, 5, order, FIVE, GFP_KERNEL));
+ XA_BUG_ON(xa, xa_get_order(xa, 5) != order);
+ XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(FIVE)) != order);
+ old = xa_cmpxchg(xa, 5, FIVE, NULL, GFP_KERNEL);
+ XA_BUG_ON(xa, old != FIVE);
+ XA_BUG_ON(xa, xa_get_order(xa, 5) != 0);
+ XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(FIVE)) != 0);
+ XA_BUG_ON(xa, xa_get_order(xa, xa_to_value(old)) != 0);
+ XA_BUG_ON(xa, !xa_empty(xa));
+}
+
static noinline void check_reserve(struct xarray *xa)
{
void *entry;
@@ -1801,6 +1821,7 @@ static int xarray_checks(void)
check_xas_erase(&array);
check_insert(&array);
check_cmpxchg(&array);
+ check_cmpxchg_order(&array);
check_reserve(&array);
check_reserve(&xa0);
check_multi_store(&array);
--
2.39.2
Powered by blists - more mailing lists