linux-kernel - Re: [PATCH v2 1/4] mm/ksm: add ksm advisor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202310281513.BWtopDPM-lkp@intel.com>
Date:   Sat, 28 Oct 2023 15:33:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stefan Roesch <shr@...kernel.io>, kernel-team@...com
Cc:     oe-kbuild-all@...ts.linux.dev, shr@...kernel.io,
        akpm@...ux-foundation.org, david@...hat.com, hannes@...xchg.org,
        riel@...riel.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/4] mm/ksm: add ksm advisor

Hi Stefan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 12d04a7bf0da67321229d2bc8b1a7074d65415a9]

url:    https://github.com/intel-lab-lkp/linux/commits/Stefan-Roesch/mm-ksm-add-ksm-advisor/20231028-081347
base:   12d04a7bf0da67321229d2bc8b1a7074d65415a9
patch link:    https://lore.kernel.org/r/20231028000945.2428830-2-shr%40devkernel.io
patch subject: [PATCH v2 1/4] mm/ksm: add ksm advisor
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231028/202310281513.BWtopDPM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231028/202310281513.BWtopDPM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310281513.BWtopDPM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/ksm.c:334: warning: Function parameter or member 'cpu_time' not described in 'advisor_ctx'


vim +334 mm/ksm.c

   321	
   322	/**
   323	 * struct advisor_ctx - metadata for KSM advisor
   324	 * @start_scan: start time of the current scan
   325	 * @scan_time: scan time of previous scan
   326	 * @change: change in percent to pages_to_scan parameter
   327	 * @cpu_percent: average cpu percent usage of the ksmd thread for the last scan
   328	 */
   329	struct advisor_ctx {
   330		ktime_t start_scan;
   331		unsigned long scan_time;
   332		unsigned long change;
   333		unsigned long long cpu_time;
 > 334	};
   335	static struct advisor_ctx advisor_ctx;
   336	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki