linux-kernel - Re: [PATCH v2 5/5] media: i2c: imx214: Fix cleanup after controls initialization error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_16L0bkjC4qnzCGgqFs45w54bbYeavvJWJqjh3=1AGHVQ@mail.gmail.com>
Date:   Sat, 28 Oct 2023 10:12:56 +0200
From:   Ricardo Ribalda Delgado <ribalda@...nel.org>
To:     André Apitzsch <git@...tzsch.eu>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        Jacopo Mondi <jacopo.mondi@...asonboard.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 5/5] media: i2c: imx214: Fix cleanup after controls
 initialization error

Hi Andre

On Sat, Oct 28, 2023 at 9:51 AM André Apitzsch <git@...tzsch.eu> wrote:
>
> Hi Ricardo,
>
> Am Samstag, dem 28.10.2023 um 09:30 +0200 schrieb Ricardo Ribalda
> Delgado:
> > Hi Andre
> >
> > On Sat, Oct 28, 2023 at 9:19 AM André Apitzsch <git@...tzsch.eu>
> > wrote:
> > >
> > > If the controls are initialized incorrectly, don't destroy the
> > > mutex not
> > > initialized yet and don't free controls as that is handled in
> > > imx214_ctrls_init().
> > >
> > > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> >
> > Since you are calling v4l2_ctrl_handler_free() in imx214_ctrls_init,
> > I think you should squash this patch with 2/5.
> >
> > Sorry for asking for a follow-up patch :S
>
> I will squash it. Shall I keep the r-b tags?

That is ok

>
> Is it okay to send the new version now?

Yes please, thanks :)

>
> >
> > Regards!
> >
> >
> > > ---
> > >  drivers/media/i2c/imx214.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/i2c/imx214.c
> > > b/drivers/media/i2c/imx214.c
> > > index e0d9624a9d3f..0aba28d6dc2f 100644
> > > --- a/drivers/media/i2c/imx214.c
> > > +++ b/drivers/media/i2c/imx214.c
> > > @@ -1069,7 +1069,7 @@ static int imx214_probe(struct i2c_client
> > > *client)
> > >
> > >         ret = imx214_ctrls_init(imx214);
> > >         if (ret < 0)
> > > -               goto free_ctrl;
> > > +               goto error_power_off;
> > >
> > >         mutex_init(&imx214->mutex);
> > >         imx214->ctrls.lock = &imx214->mutex;
> > > @@ -1100,6 +1100,7 @@ static int imx214_probe(struct i2c_client
> > > *client)
> > >  free_ctrl:
> > >         mutex_destroy(&imx214->mutex);
> > >         v4l2_ctrl_handler_free(&imx214->ctrls);
> > > +error_power_off:
> > >         pm_runtime_disable(imx214->dev);
> > >
> > >         return ret;
> > >
> > > --
> > > 2.42.0
> > >
>