linux-kernel - Re: [PATCH] dmaengine: apple-admac: Keep upper bits of REG_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <00401D09-6037-44AE-91CC-34379ED9589E@cutebit.org>
Date:   Sun, 29 Oct 2023 18:10:41 +0100
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        Vinod Koul <vkoul@...nel.org>
Cc:     Alyssa Rosenzweig <alyssa@...enzweig.io>, asahi@...ts.linux.dev,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        dmaengine@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: apple-admac: Keep upper bits of REG_BUS_WIDTH


> On 29. 10. 2023, at 18:00, Martin Povišer <povik+lin@...ebit.org> wrote:
> 
> From: Hector Martin <marcan@...can.st>
> 
> For RX channels, REG_BUS_WIDTH seems to default to a value of 0xf00, and
> macOS preserves the upper bits when setting the configuration in the
> lower ones. If we reset the upper bits to 0, this causes framing errors
> on suspend/resume (the data stream "tears" and channels get swapped
> around). Keeping the upper bits untouched, like the macOS driver does,
> fixes this issue.
> 
> Signed-off-by: Hector Martin <marcan@...can.st>
> Reviewed-by: Martin Povišer <povik@...ebit.org>
> Signed-off-by: Martin Povišer <povik@...ebit.org>
> ---

Please take up v2 instead. I slipped in the wrong email address in here,
which I don’t want to subscribe for kernel spam with.

https://lore.kernel.org/dmaengine/20231029170704.82238-1-povik+lin@cutebit.org/T/#u

Thanks!

Kind regards,
Martin